-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 340 - updates to metrics collection to use modal ux #359
Conversation
src/index.html
Outdated
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/tachyons@4.11.1/css/tachyons.min.css" | ||
integrity="sha256-XiJ+PedljEmPP2VaQzSzekfCZdPr0fpqmh9dY6kpsuQ=" crossorigin="anonymous"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should prioritize imports in javascript instead of managing in html
src/index.html
Outdated
<link href="styles.css?v=0.4" type="text/css" rel="stylesheet"/> | ||
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/tachyons@4.11.1/css/tachyons.min.css" | ||
integrity="sha256-XiJ+PedljEmPP2VaQzSzekfCZdPr0fpqmh9dY6kpsuQ=" crossorigin="anonymous"> | ||
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/ipfs-css@0.13.1/ipfs.css" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
<img src="https://ipfs.io/ipfs/QmTqZhR6f7jzdhLgPArDPnsbZpvvgxzCZycXK7ywkLxSyU?filename=ipfs-logo.3ea91a2f.svg" | ||
alt="IPFS" height="50px" width="117.5px" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use git add -p
to ensure you're not committing your own formatting changes
@@ -1,30 +1,38 @@ | |||
<!DOCTYPE html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't tell what's legitimately changed in this file versus what the formatting changes are. If you want to update formatting, we should do so in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function loadCountly (): void { | ||
bannerToggle?.addEventListener('click', bannerToggleEventHandler) | ||
metricsModalToggle?.addEventListener('click', metricsModalToggleEventHandler) | ||
Countly.init({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could probably remove all the non-DOM related stuff and replace it with an import and proper usage of ignite-metrics
body, html { | ||
box-sizing: border-box; | ||
text-align: center; | ||
body, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
separate formatting changes and code changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #366.
Testing the changes on the preview build look good except for one thing: Metrics are disabled upon page load: we could probably address this issue and a few of my comments on this PR in another issue, #367 |
* Adding service worker * Registering service worker * Removing version cache busting strategy
Replaced by #373 |
@SgtPooki closing this PR in preference of #373 after the formatting cleanup