Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ipfs.cyou #579

Merged
merged 2 commits into from
Aug 29, 2024
Merged

feat: add ipfs.cyou #579

merged 2 commits into from
Aug 29, 2024

Conversation

smurfix
Copy link
Contributor

@smurfix smurfix commented Jun 27, 2024

This is a well-connected server in Nürnberg Germany. Free bandwidth limited based on usage; faster paid access will be added later this year.

@smurfix smurfix requested a review from a team as a code owner June 27, 2024 19:27
Copy link

welcome bot commented Jun 27, 2024

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@@ -1,4 +1,5 @@
[
"https://ipfs.cyou",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smurfix I think you need to fix TLS setup. Currently, you have wildcard at wrong place:

2024-06-27_22-22

TLS wildcards work only for one level up. Due to this, you need to set up additional TLS wildcard certificates for DNS Names one subdomain higher: *.ipfs.ipfs.cyou and *.ipns.ipfs.cyou.

See https://docs.ipfs.tech/how-to/address-ipfs-on-web/#subdomain-gateway

You can reproduce with below:

Copy link
Contributor Author

@smurfix smurfix Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm already working on it. Unfortunately my DNS secondaries sometimes decide not to listen to update notifications.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, now uses working wildcard certificates.

@SgtPooki SgtPooki requested a review from lidel June 28, 2024 15:12
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cert issues look to be cleared up. https://specs-ipfs-tech.ipns.ipfs.cyou/ works and so does bafkreibm6jg3ux5qumhcn2b3flc3tyu6dmlb4xa7u5bf44yegnrjhc4yeq.ipfs.ipfs.cyou

@lidel lidel merged commit 66cb2f7 into ipfs:main Aug 29, 2024
16 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 29, 2024
## [1.12.0](v1.11.0...v1.12.0) (2024-08-29)

### Features

* add ipfs.cyou ([#579](#579)) ([66cb2f7](66cb2f7))
Copy link

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants