fix: fix unixfs directory redirects #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 35 35
Branches 5 5
=========================================
Hits 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SgtPooki
commented
Mar 25, 2024
|
|
||
| const headers = request.headers | ||
| headers.forEach((value, key) => { | ||
| log.trace('fetchHandler: request headers: %s: %s', key, value) | ||
| }) | ||
|
|
||
| const response = await verifiedFetch(verifiedFetchUrl, { | ||
| const response = await verifiedFetch(event.request.url, { |
There was a problem hiding this comment.
we no longer need a lot of the URL manipulating code (which was adding a trailing slash and not allowing verified-fetch unixfs dir redirect to work properly)
| import drain from 'it-drain' | ||
| import type { Controller } from 'ipfsd-ctl' | ||
|
|
||
| export async function loadFixtureDataCar (controller: Controller, path: string): Promise<void> { |
There was a problem hiding this comment.
same as https://github.com/ipfs/helia-verified-fetch/blob/main/packages/interop/src/fixtures/load-fixture-data.ts except for fixture data path
| import { path as kuboPath } from 'kubo' | ||
| import * as kuboRpcClient from 'kubo-rpc-client' | ||
|
|
||
| export async function createKuboNode (): Promise<Controller> { |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix: fix unixfs directory redirects
Description
Started as e2e test addition for "Opening a directory with index.html returns index.html" mentioned at #134, ended up fixing #62 and adding a test for it.
Summary of changes:
Notes & open questions
N/A
Change checklist