test: e2e test and fixture overhaul #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: single kubo gateway for parallel tests chore: attempting to remove beforeEach for byte-ranges chore: working on dx for e2e chore: move gateway conformance to global setup/teardown test: e2e fixtures for subdomain and path routing chore: remove unnecessary service worker wait
SgtPooki
commented
Mar 26, 2024
| if (partialText == null) throw new Error('missing response') | ||
| test('can get trailing byte range from car with missing data', async ({ page }) => { | ||
| const { bytes, byteSize, statusCode } = await doRangeRequest({ page, range: 'bytes=2200-', path: '/ipfs/QmYhmPjhFjYFyaoiuNzYv8WGavpSRDwdHWe5B4M5du5Rtk' }) | ||
| // TODO: do we need to check the full 872 bytes...? |
There was a problem hiding this comment.
idk if theres some block-crossing logic we want to check here, or if checking the size is sufficient, @lidel
| @@ -0,0 +1,124 @@ | |||
| /** | |||
There was a problem hiding this comment.
this was ported over from helia-http-gateway and improved slightly
| const controller = await createKuboNode() | ||
| await Promise.all([controller.start(), loadKuboFixtures()]) | ||
|
|
||
| process.env.KUBO_PID = `${await controller.pid()}` |
There was a problem hiding this comment.
i thought we would need this to kill the kubo instance, but it seems like playwright handles it?
| import { kuboRepoDir } from './fixtures/load-kubo-fixtures.js' | ||
|
|
||
| export default async function globalTeardown (config: Config): Promise<void> { | ||
| await $`rm -rf ${kuboRepoDir}` |
There was a problem hiding this comment.
I thought about pushing up the kubo repo just to simplify things, but that feels bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
test: e2e test and fixture overhaul
Description
A pretty significant improvement to the way tests can be written, and use of local kubo gateway across tests. Need to debug in CI since pulling fixtures depends on
dockerbeing available.Summary of changes
./test-e2e/fixtures/routing-test-fixtures.tswhich automatically sets SW config./test-e2e/fixtures/load-kubo-fixtures.tsdo-range-requesttest to test range requests more easily./test-e2e/locators.tsthat help with configuration setting via UI, and functions to use them:setConfigViaUiSubdomainandsetConfigViaUi, though they are currently unused.Notes & open questions
I will probably merge this once I get the CI passing.
Change checklist