-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make routers optional and enable local insecure gateways #303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not run it locally yet, but dropping quick feedback / questions in the meantime.
Co-authored-by: Marcin Rataj <lidel@lidel.org>
I'm currently blocked by a bug I found, where verifiedFetch does not respect the I have a reproduction here: https://codepen.io/2color/pen/VwOXeMz. But I haven't been able to find out where the root of the problem is. Still digging into this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have testing in place for this, so each flow needs to be inspected manually.
I did some testing in vanilla Google Chrome (empty profile each time) and both need a bit more polish.
- Localhost detection works only when dancing a specific way:
- 🟢 Works when visiting the main domain first (
http://test1.localhost:3000/
) and then manually open config detects and prepends mylocalhost:8080
gateway, and uses it just fine - 🚧 Does not work when visiting the main domain first with config URL opened (
http://test2.localhost:3000/#/ipfs-sw-config
) - 🚧 Does not work if I visit subdomain first (
http://specs-ipfs-tech.ipns.test3.localhost:3000/
does not prepend localhost) - ⭕ The detection does dot work in Brave because they have very strick adblock (Brave Shields) rules:
Due to this, a big chunk of audience won't be able to benefit from this anyway 😞
- 🟢 Works when visiting the main domain first (
- Disabling delegated routing works, but does more harm than good, making it not useful:
- 🚧 Disabling delegated routing breaks DNSLink resolution (example), while it should only impact IPNS and not DNSLink
Between localhost detection and adjusting things in https://github.com/ipshipyard/waterworks-infra/issues/55 the latter improves things in all browsers, so we may want to park this and focus on that + the other quality-of-life improvements from the Camp milestone.
I feel we will get back to this once we simplify codebase after Camp. Right now, too much of a time sink.
Added by this PR:
routers
configuration will not be passed to Helia.Fixes #299 #288
Notes & open questions
Change checklist