WIP: exchange spec #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| `fn get(Multihash: key) -> (Vec<u8>: block, Err: err)` | ||
| `fn put(Multihash: key, Vec<u8>: block) -> Err: err` | ||
|
|
||
| Q: bitswap should not expect an already serialized block so that we can pick the serialization format inside when passing it around. |
There was a problem hiding this comment.
@whyrusleeping I'm trying to come with a best way to enable cbor and protobuf to coexist. We will need to make it very explicit or just let bitswap figure out how to encode something.
Also, right now blocks in datastore are stored as .data, we can have .data for serialized protobufs and .cbor for serialized IPLD objects.
Thoughts?
There was a problem hiding this comment.
.data is very generic. How about .proto for Protobufs, and .cbor for serialized IPLD.
This was referenced Dec 21, 2015
|
going to open a new one :) |
|
See #95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.