structure refresh #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
|  | ||
| > This repository contains the specs for the IPFS Protocol and associated subsystems. Some day we will hopefully transform these specs into RFCs. For now, they assume a high level of familiarity with the concepts. |
There was a problem hiding this comment.
The > section should match the repo description.
There was a problem hiding this comment.
Updated it to: This repository contains the specs for the IPFS Protocol and associated subsystems.. Sounds good?
There was a problem hiding this comment.
Better to have this paragraph beneath, just not with a >. Put the > above it, the one you corrected it to.
|
Overall good. Some comments. |
| @@ -0,0 +1,102 @@ | |||
| CLI - Command Line Interface | |||
| ============================ | |||
There was a problem hiding this comment.
@RichardLitt CLI stuff is here :)
daviddias
force-pushed
the
spec-refresh
branch
4 times, most recently
from
81e6ee9
to
21cf600
Compare
|
Thank you @RichardLitt, made changes following your comments. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR with structure refresh. Biggest contribution is updating the specs list with the specs that we have and that need to have.
Will continue working on separate PRs for the specs that still don't exist.