Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

sync: update CI config files #3

Merged
merged 3 commits into from
Jun 22, 2021
Merged

sync: update CI config files #3

merged 3 commits into from
Jun 22, 2021

Conversation

web3-bot
Copy link
Collaborator

Syncing to commit protocol/.github@adea1c0.

marten-seemann
marten-seemann previously approved these changes Jun 18, 2021
@aschmahmann
Copy link
Contributor

going to wait on this PR for a bit until #1 and #2 are taken care of.

@marten-seemann
Copy link
Member

Why not merge this one first and rebase the other PRs? Then you'd already get CI checks on those.

@marten-seemann
Copy link
Member

I just rebased this PR, and ran into a bunch of merge conflicts.

Lessons learned for future deployments to new repositories:

  • We should avoid copying go-test.yml and go-check.yml manually. These files are only supposed to be touched by the Unified CI Setup workflows.
  • The PR adding / updating the workflows (i.e., this PR here) should be merged asap, and feature-PRs should be rebased once it is merged.

@marten-seemann marten-seemann merged commit 911562c into master Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants