Async handler #32
Merged
Async handler #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly copies code, some optimization, brings up tests cases. Not actually fully async yet because ultimately calls sync code via the requests library.
|
The only step left is to replace the |
|
Last step is to document in README.md. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
The async handler will be available through a
getHandlerAsyncfunction, which returns aAsyncHandlerobject, different from thegetHandlerfunction returning the synchronousHandler.Keeping the code completely separate is likely the most sensible solution in practice - if you're using async, you likely always want async stuff, so you don't care about the sync code. And if you're using sync, you likely are doing so because you can't use the async stuff. This separation allows us to change the two implementations totally in isolation.