Update usage of merkledag by go-car #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this updates to merkledag v0.11 in go-car v1 * it removes direct usage of merkledag from go-car v2 Note that merkledag remains an indirect dependency for v2 via: ``` % go mod why github.com/ipfs/go-merkledag github.com/ipld/go-car/v2 github.com/ipld/go-car/v2.test github.com/ipfs/go-unixfsnode github.com/ipfs/go-unixfsnode/hamt github.com/ipfs/go-unixfsnode/hamt.test github.com/ipfs/go-merkledag ``` This usage to generate a sample dag can likely also be removed in the future
masih
approved these changes
Jun 12, 2023
|
fixes #266 |
|
shoudl we merge @willscott or wait for @rvagg ? |
rvagg
approved these changes
Jun 13, 2023
|
going to merge this and work on the new dependabot updates which overlap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that merkledag remains an indirect dependency for v2 via:
This usage to generate a sample dag can likely also be removed in the future