Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: opt-in way to allow empty list of roots in CAR headers #461

Merged
merged 4 commits into from
Aug 3, 2023
Merged

fix: opt-in way to allow empty list of roots in CAR headers #461

merged 4 commits into from
Aug 3, 2023

Commits on Jul 13, 2023

  1. Don't error making a car reader if there is no root specified

    @willscott
    willscott committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    27aa3b5 View commit details
    Browse the repository at this point in the history

  2. remove testcase that's now valid

    @willscott
    willscott committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    233cf47 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Use an options pattern for better backwards compatibility

    @willscott
    willscott committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    6250fa4 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. refactor: WithErrorOnEmptyRoots(bool) 

    this allows us to keep backward compatibility
and explicitly enable both behaviors, which means
code that expects error can be migrated into implicit flag
over time
    @lidel
    lidel committed Jul 31, 2023
    2 Configuration menu
    Copy the full SHA
    67151fc View commit details
    Browse the repository at this point in the history