Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error handling and change signature of Tx{In, Out}.WriteTo #26

Merged
merged 1 commit into from
Mar 22, 2021
Merged

fix error handling and change signature of Tx{In, Out}.WriteTo #26

merged 1 commit into from
Mar 22, 2021

Conversation

marten-seemann
Copy link
Collaborator

@marten-seemann marten-seemann commented Mar 13, 2021 •
edited
Loading

Fixes #24.

This fixes the go vet failures, see discussion in #24.

@marten-seemann marten-seemann requested review from rvagg and mvdan March 13, 2021 04:01
mvdan
mvdan approved these changes Mar 22, 2021
View reviewed changes
Copy link

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old code also seemed to ignore some errors, which looks a bit worrying. LGTM on both counts.

@marten-seemann marten-seemann merged commit 5559857 into ipld:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

@rvagg rvagg Awaiting requested review from rvagg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go vet asks us to change to change Tx{In, Out}.WriteTo signature
2 participants
@marten-seemann @mvdan