schema,tests,gen/go: more tests, gen union fixes. #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
reviewed
Sep 24, 2021
mvdan
approved these changes
Sep 24, 2021
…t suites markedly. Fixes a few old todos in the test system for typed nodes. The additional exercise picks up some bugs in the codegen for unions. (This was also reported by Adin, and I think possibly by Ian earlier, though I only got around to reproducing it fully now.) Those bugs -- off-by-ones; uuf -- are now fixed. Some todos were encountered in bindnode by the new coverage too. Only one thing. But it's a bit more than I knew how to fix in one sitting, so I've made that test skipped for now, hopefully to be fixed soon. Some error messages that confused me along the way are tweaked. The datamodel.DeepEquals method is slightly less fragile on nils.
warpfork
force-pushed
the
union-fixes-and-more-tests
branch
from
3d4dba4
to
79a0220
Compare
|
Added tests and made nils equal nils as suggested. Thanks for those. Will probably merge this shortly if not further objections; I think that addressed everything. |
|
go ahead! |
mvdan
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the coverage produced by the schema test suites markedly, fixing a few old todos in the test system for typed nodes.
The additional exercise picks up some bugs in the codegen for unions.
(This was also reported by Adin, and I think possibly by Ian earlier,
though I only got around to reproducing it fully now.) Those bugs --
off-by-ones; uuf -- are now fixed.
Some todos were encountered in bindnode by the new coverage too.
Only one thing. But it's a bit more than I knew how to fix in one
sitting, so I've made that test skipped for now, hopefully to be
fixed soon.
Some error messages that confused me along the way are tweaked.
The datamodel.DeepEquals method is slightly less fragile on nils.