-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: more. #279
storage: more. #279
Commits on Oct 30, 2021
-
storage: many more adapters; a new filesystem storage implementation;…
… benchmark helper functions; and actual benchmark tables, runnable, which compare several storage implementations.
Configuration menu - View commit details
-
Copy full SHA for 67c65ae - Browse repository at this point
Copy the full SHA 67c65aeView commit details -
storage: extract readmes about adapters.
Mostly deredundantizing, but made a few improvements as well.
Configuration menu - View commit details
-
Copy full SHA for 4d9e5f2 - Browse repository at this point
Copy the full SHA 4d9e5f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 125c81f - Browse repository at this point
Copy the full SHA 125c81fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab1d2c7 - Browse repository at this point
Copy the full SHA ab1d2c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd20a2f - Browse repository at this point
Copy the full SHA fd20a2fView commit details -
storage: update fsstore defaults to be the same as flatfs as used by …
…default configuration of go-ipfs. Include links to where the relevant ipfs code can be found. (It's not all in very obvious places, and not all in the go-ipfs repo.) Extracted some of the b32 encoder to a package function... but, although this does avoid some repeated initialization, it was all CPU stuff. Benchmarks indicate that it made no real difference. So it's mostly a stylistic change.
Configuration menu - View commit details
-
Copy full SHA for 6ea5215 - Browse repository at this point
Copy the full SHA 6ea5215View commit details
Commits on Nov 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 532c290 - Browse repository at this point
Copy the full SHA 532c290View commit details
Commits on Nov 8, 2021
-
One level with fmt.Sprintf is enough for what we need, and is also easier to follow.
Configuration menu - View commit details
-
Copy full SHA for 9269140 - Browse repository at this point
Copy the full SHA 9269140View commit details
Commits on Nov 10, 2021
-
storage benchmarks: use testing package's tmpdirs.
... which is actually important, not just stylistic: this also makes the benchmarks much more correct, because we were previously doing the cleanup work on the clock! Now the cleanup is done by the test system, off the clock. This fixes results to actually be, um, correct. *facepalm*.
Configuration menu - View commit details
-
Copy full SHA for f020fd6 - Browse repository at this point
Copy the full SHA f020fd6View commit details -
The storage APIs now require this and caution of potential resource leakage otherwise.
Configuration menu - View commit details
-
Copy full SHA for ba94a80 - Browse repository at this point
Copy the full SHA ba94a80View commit details -
storage benchmarks: it would be preferable to actually use the shardi…
…ng parameters that are in fact "default" when comparing these.
Configuration menu - View commit details
-
Copy full SHA for 888bbea - Browse repository at this point
Copy the full SHA 888bbeaView commit details
Commits on Nov 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 893d825 - Browse repository at this point
Copy the full SHA 893d825View commit details -
storage: switch storage.StreamingReadableStorage.GetStream to return …
…an io.ReadCloser instead of just io.Reader. This seems more likely to encourge good code that doesn't leak resources than just admonishing people to check via a comment. On the downside, sometimes this requires implementations to wrap stuff in no-op closers. The trade is probably worth it. The code in LinkSystem which uses these things still doesn't change. It's still using the `linking.Block*Opener` functions, which still return just io.Reader. And we're considerably less free to change those, because there are already quite a few implementations of those types in the wild, and we don't want to break them.
Configuration menu - View commit details
-
Copy full SHA for 60b0f8c - Browse repository at this point
Copy the full SHA 60b0f8cView commit details -
storage: avoid io.NopCloser; it was relatively recently introduced.
(I think our policy is roughly "support the last two significant go versions", and by that, we might technically be allowed to use this, but, eh; there's minimal cost to being conservative today.)
Configuration menu - View commit details
-
Copy full SHA for e99bcd1 - Browse repository at this point
Copy the full SHA e99bcd1View commit details