Make traversal.WalkTransforming() work #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @EdSchouten! Would you mind having a look at the tests to see if you can either add a new one or adjust an existing one to exercise this? |
It looks like the current implementation never calls Selector.Decide(), meaning it always attempts to transform the root node, even if it shouldn't be matched.
EdSchouten
force-pushed
the
eschouten/20230424-walk-transforming
branch
from
ea97bc8 to
2944c1a
Compare
|
Sure thing! I've just added some basic testing coverage, based on the tests we already have for WalkMatching(). I have confirmed that these tests fail if this change is not applied. Hope that helps! |
rvagg
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the current implementation never calls Selector.Decide(), meaning it always attempts to transform the root node, even if it shouldn't be matched.