-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: publish as esm-only #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following on from the conversation in ipld/ipld#224 this converts this repo to use the latest aegir with Unified CI. 1. Remove all build related dev deps apart from `aegir` 1. Run the `npx aegir check-project` command to update project config 1. Remove non-Unified-CI github actions 1. Update imports to import from `src/index.js` instead of `@ipld/dag-pb` 1. Rename `test/*.js` to `test/*.spec.js` so aegir can find them 1. Update `tsconfig.json` to extend config from `aegir` 1. Remove `"main"` and other unused fields from `package.json` 1. Use `chai` from `aegir` pre-configured with plugins we use 1. Fixes everything the linter complains about This will need a follow up PR to `protocol/.github` to add this repo to the Unified CI [config file](https://github.com/protocol/.github/blob/master/configs/js.json) so it'll get automated config updates in the future. Apologies that this PR is so noisy, most of it is from the `check-project` command
rvagg
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 nice work
To roll the multiformats upgrade in here this will need: |
rvagg
reviewed
Oct 19, 2022
Co-authored-by: Rod Vagg <rod@vagg.org>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
## [8.0.0](v7.0.3...v8.0.0) (2022-10-19) ### ⚠ BREAKING CHANGES * publish as esm-only (#71) ### Features * publish as esm-only ([#71](#71)) ([807fdd4](807fdd4)) ### Trivial Changes * **no-release:** bump actions/setup-node from 3.4.1 to 3.5.0 ([#68](#68)) ([4716850](4716850)) * **no-release:** bump actions/setup-node from 3.5.0 to 3.5.1 ([#70](#70)) ([14f9cdc](14f9cdc))
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the conversation in ipld/ipld#224 this converts this repo to use the latest aegir with Unified CI.
aegir
npx aegir check-project
command to update project configsrc/index.js
instead of@ipld/dag-pb
test/*.js
totest/*.spec.js
so aegir can find themtsconfig.json
to extend config fromaegir
"main"
and other unused fields frompackage.json
chai
fromaegir
pre-configured with plugins we useThis will need a follow up PR to
protocol/.github
to add this repo to the Unified CI config file so it'll get automated config updates in the future.Apologies that this PR is so noisy, most of it is from the
check-project
command