Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Repurpose ipfs-block as a container for { data, cid } #25

Closed
kumavis opened this issue Dec 19, 2016 · 1 comment
Closed

Repurpose ipfs-block as a container for { data, cid } #25

kumavis opened this issue Dec 19, 2016 · 1 comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/community-input Needs input from the wider community

Comments

@kumavis
Copy link

kumavis commented Dec 19, 2016 •
edited by dignifiedquire
Loading

currently it is a wrapper around the data that adds a utility method for generating the multihash.

block.key(hashFn, cb) is not much better than hash(hashFn, block.data, cb).

Instead I propose we repurpose this as a container around { data, cid } since that is not captured in a standard interface yet but use it in a number of places.
@kumavis kumavis mentioned this issue Dec 19, 2016
Merged
@daviddias daviddias added the status/ready Ready to be worked label Dec 20, 2016
@dignifiedquire dignifiedquire added need/community-input Needs input from the wider community kind/enhancement A net-new feature or improvement to an existing feature labels Dec 20, 2016
@daviddias daviddias added status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Jan 29, 2017
@daviddias
Copy link
Member

Happening here: #31

@daviddias daviddias removed the status/deferred Conscious decision to pause or backlog label Mar 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/community-input Needs input from the wider community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dignifiedquire @daviddias @kumavis