feat/use new bitswap #51
Conversation
| @@ -21,7 +21,7 @@ module.exports = class BlockService { | |||
| } | |||
|
|
|||
| isOnline () { | |||
| return this._bitswap != null | |||
| return this._bitswap !== null | |||
There was a problem hiding this comment.
please don't, != checks for both null and undefined
There was a problem hiding this comment.
Well.. you are always setting it up to null, if it happens to be undefined then probably something weird happened, but ok, I can revert
| } else { | ||
| ps = this._repo.blockstore.putStream() | ||
| return pull( | ||
| pull.map((blockAndCID) => { |
There was a problem hiding this comment.
I would really like to change this, currently we are going from having a Block, to this strange object, and inside bitswap back to a Block. Can we please make the Block interface sufficient so we can pass it through the whole stack?
There was a problem hiding this comment.
Wait, BlockService is blockAndCID and now bitswap is also blockAndCID, because bitswap needs to know CIDs, where do we in Bitswap move it to just Block?
There was a problem hiding this comment.
looks like the old inefficiency in bitswap is gone with the refactor, then I'm fine with this :)
There was a problem hiding this comment.
Btw, I would love to have something nicer, the blockAndCID isn't my favourite, but we really can't use something as Block right now unless we 'patch' it every time to have the right CID, which won't happen when reading from the repo, and there the only identifier is the multihash. Right now, Block is really just a buffer + a convenience method that invokes multihashing, it might make sense to do what @kumavis brought up in the last call and just remove that type and do { data: cid: } objects all the way. (Still not convinced of what is simpler)
There was a problem hiding this comment.
yeah ipfs-block should just wrap { data, cid }
ipld/js-ipld-block#25
There was a problem hiding this comment.
I think with the info about the repo changes in go-ipfs we will have to rethink this anway.
daviddias
force-pushed
the
feat/use-new-bitswap
branch
from
03f52a0 to
c2499d1
Compare
daviddias
force-pushed
the
feat/use-new-bitswap
branch
from
c2499d1 to
f0c3e42
Compare
|
🎉 |
depends on ipfs/js-ipfs-bitswap#76