This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
fix: allow adding links from DAGNode.Links #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DAGNode.Links` converts `DAGLink` objects into vanilla JS objects. `DAGNode.addLink` accepts vanilla JS objects as links but looks for different properties from the ones the return value of `DAGNode.Links` have (e.g. `.Hash` vs `.cid`, etc).. This PR corrects the behaviour to look for those properties names and adds a test.
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 94.11% 94.53% +0.42%
==========================================
Files 15 15
Lines 238 238
==========================================
+ Hits 224 225 +1
+ Misses 14 13 -1
Continue to review full report at Codecov.
|
alanshaw
approved these changes
May 17, 2019
vmx
approved these changes
May 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAGNode.LinksconvertsDAGLinkobjects into vanilla JS objects.DAGNode.addLinkaccepts vanilla JS objects as links but looks for different properties from the ones the return value ofDAGNode.Linkshave (e.g..Hashvs.cid, etc)..This PR corrects the behaviour to look for those properties names and adds a test for the same.