Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: publish as esm-only #36

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

achingbrain
Copy link
Member

Following on from the conversation in ipld/ipld#224 this converts this repo to use the latest aegir with Unified CI.

  1. Remove all dev deps apart from aegir
  2. Run the npx aegir check-project command to update project config
  3. Remove non-Unified-CI github actions
  4. Update imports to import from src/index.js instead of ipld-garbage
  5. Rename test/*.js to test/*.spec.js so aegir can find them
  6. Update tsconfig.json to extend config from aegir
  7. Remove "main" and other unused fields from package.json
  8. Use chai from aegir pre-configured with plugins we use
  9. Fixes everything the linter complains about
  10. Upgrades multiformats to 10.x.x

This will need a follow up PR to protocol/.github to add this repo to the Unified CI config file so it'll get automated config updates in the future.

Apologies that this PR is so noisy, most of it is from the check-project command

Following on from the conversation in ipld/ipld#224 this converts this repo to use the latest aegir with Unified CI.

1. Remove all dev deps apart from `aegir`
1. Run the `npx aegir check-project` command to update project config
1. Remove non-Unified-CI github actions
1. Update imports to import from `src/index.js` instead of `ipld-garbage`
1. Rename `test/*.js` to `test/*.spec.js` so aegir can find them
1. Update `tsconfig.json` to extend config from `aegir`
1. Remove `"main"` and other unused fields from `package.json`
1. Use `chai` from `aegir` pre-configured with plugins we use
1. Fixes everything the linter complains about
1. Upgrades multiformats to 10.x.x

This will need a follow up PR to `protocol/.github` to add this repo to the Unified CI [config file](https://github.com/protocol/.github/blob/master/configs/js.json) so it'll get
automated config updates in the future.

Apologies that this PR is so noisy, most of it is from the `check-project` command
@socket-security
Copy link

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
esbuild@0.14.39 (added) postinstall package.json via aegir@37.5.6, playwright-test@8.1.1
esbuild@0.15.11 (added) postinstall package.json via aegir@37.5.6
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 2 new install scripts detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore esbuild@0.14.39
  • @SocketSecurity ignore esbuild@0.15.11

Powered by socket.dev

@rvagg
Copy link
Member

rvagg commented Oct 19, 2022

@achingbrain I wouldn't mind renaming this to @ipld/garbage now that I've moved it into the org here; would that be too much trouble to include here? We probably need to get a new npm token in here too.

@achingbrain
Copy link
Member Author

I've renamed it the module.

We probably need to get a new npm token in here too.

Can you add w3dt-stewards as admins to this repo please?

@achingbrain achingbrain merged commit 464080f into ipld:master Oct 19, 2022
@achingbrain achingbrain deleted the feat/publish-as-esm-only branch October 19, 2022 09:16
github-actions bot pushed a commit that referenced this pull request Oct 19, 2022
## [6.0.0](v5.0.0...v6.0.0) (2022-10-19)

### ⚠ BREAKING CHANGES

* publish as esm-only (#36)

### Features

* publish as esm-only ([#36](#36)) ([464080f](464080f))

### Trivial Changes

* **no-release:** bump actions/setup-node from 3.3.0 to 3.4.0 ([#30](#30)) ([f5bb329](f5bb329))
* **no-release:** bump actions/setup-node from 3.4.0 to 3.4.1 ([#31](#31)) ([69e12de](69e12de))
* **no-release:** bump actions/setup-node from 3.4.1 to 3.5.0 ([#32](#32)) ([27a9d56](27a9d56))
* **no-release:** bump actions/setup-node from 3.5.0 to 3.5.1 ([#34](#34)) ([81dab8c](81dab8c))

### Documentation

* update readme badges and repo links ([cfe5d1b](cfe5d1b))
@github-actions
Copy link

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants