This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
feat: new IPLD Format API #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 86 65 -21
=====================================
- Hits 86 65 -21
Continue to review full report at Codecov.
|
rvagg
reviewed
Apr 24, 2019
| const traverse = function * (node, path) { | ||
| // Traverse only objects and arrays | ||
| if (Buffer.isBuffer(node) || CID.isCID(node) || typeof node === 'string' || | ||
| node === null) { |
rvagg
reviewed
Apr 24, 2019
test/resolver.spec.js
Outdated
| it('should return the version', (done) => { | ||
| verifyPath(fixtureBlockHeader, 'version', 4, done) | ||
| it('should return the version', async () => { | ||
| await verifyPath(fixtureBlockHeader, 'version', 4) |
rvagg
reviewed
Apr 24, 2019
test/resolver.spec.js
Outdated
| done() | ||
| }) | ||
| const verifyError = async (block, path, error) => { | ||
| await expect( |
There was a problem hiding this comment.
this can be replaced with a return and probably even remove the async so it's just a simple Promise returning function
There was a problem hiding this comment.
I'll keep the async as I like to signal that it's returning a Promise. As it's in tests I don't mind the performance implications (in case there are any).
|
|
rvagg
approved these changes
May 1, 2019
BREAKING CHANGE: The API is now async/await based There are numerous changes, the most significant one is that the API is no longer callback based, but it using async/await. For the full new API please see the [IPLD Formats spec]. [IPLD Formats spec]: https://github.com/ipld/interface-ipld-format
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The API is now async/await based
There are numerous changes, the most significant one is that the API
is no longer callback based, but it using async/await.
For the full new API please see the IPLD Formats spec.