This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
feat: expose getFormat function #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's useful to be able to get the format implementations out of ipld just before `ipld.put` operations in the HTTP API server of IPFS. This is because we've serialized the node on the client for transmission over HTTP so need to deserialize it before passing it into `ipld.put` for it to be serialized (and as such, verified) again. We can duplicate the list of resolvers and logic behind the addition of new resolvers from ipld or we can just expose the `getFormat` function which we do here to reduce any code duplication.
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 3 3
Lines 153 153
=======================================
Hits 135 135
Misses 18 18
Continue to review full report at Codecov.
|
rvagg
approved these changes
Oct 27, 2020
vmx
approved these changes
Oct 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to be able to get the format implementations out of ipld
just before
ipld.putoperations in the HTTP API server of IPFS.This is because we've serialized the node on the client for transmission
over HTTP so need to deserialize it before passing it into
ipld.putfor it to be serialized (and as such, verified) again.
We can duplicate the list of resolvers and logic behind the addition
of new resolvers from ipld or we can just expose the
getFormatfunctionwhich we do here to reduce any code duplication.