Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade index-provider in lotus #238

Closed
masih opened this issue Jun 20, 2022 · 9 comments
Closed

Upgrade index-provider in lotus #238

masih opened this issue Jun 20, 2022 · 9 comments
Assignees

Comments

@masih
Copy link
Member

masih commented Jun 20, 2022

Trickle dependencies up stream and upgrade index-provider in lotus.
This needs an upgrade to go-fil-market first then lotus.

@masih masih self-assigned this Jun 20, 2022
@masih
Copy link
Member Author

masih commented Jun 20, 2022

Upgrading the go-fil-market is blocked by older libp2p dependencies in go-data-transfer. More specifically, a breaking API change in mocknet package used here.

@jennijuju I think libp2p dependencies in go-data-transfer need to be upgraded before we can push ahead with this.

Thoughts?

@jennijuju
Copy link

@hannahhoward @dirkmc how do you feel about the above dep update in gdt?

fyi - in lotus we have already bumped to github.com/libp2p/go-libp2p v0.19.4, github.com/libp2p/go-libp2p-core v0.15.1 so we already have that breaking change.

@hannahhoward
Copy link
Collaborator

Hey @jennijuju we have bumped already for go-data-transfer v2, but can backport to v1 -- is this for v17.1 release? We are targeting v17.2 for go-data-transfer v2.

@jennijuju
Copy link

@hannahhoward this is for v1.17.0 (current train) actually - as indexer provider is "broken" in lotus market atm.

@hannahhoward
Copy link
Collaborator

oh sorry... I mean 0.17.0 for backport, 0.17.1 for v2

@hannahhoward
Copy link
Collaborator

@jennijuju
Copy link

https://github.com/filecoin-project/go-data-transfer/releases/tag/v1.15.2

@masih
Copy link
Member Author

masih commented Jun 22, 2022

@jennijuju Update on this: go-fil-markets upgraded and released. Upgrade in Lotus, however will require a range of upgrades across dependencies due to breaking changes in go-cid 0.2.0. Off the top of my head the dependencies include:

  • ffi
  • go-car/v2
  • go-ipfs-http-client

@jennijuju
Copy link

@jennijuju Update on this: go-fil-markets upgraded and released. Upgrade in Lotus, however will require a range of upgrades across dependencies due to breaking changes in go-cid 0.2.0. Off the top of my head the dependencies include:

  • ffi
  • go-car/v2
  • go-ipfs-http-client

im okay with updating those deps! for ffi - can we also backport it on top of https://github.com/filecoin-project/filecoin-ffi/tree/acda280d74047ee7b247ffb8463cf29f1f108560 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants