Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: market: upgrade index-provider and related dependencies #8890

Closed
wants to merge 6 commits into from

Conversation

masih
Copy link
Member

@masih masih commented Jun 22, 2022

Related Issues

Proposed Changes

Upgrade index-provider to the latest and upgrade all related dependencies, including go-fil-market upgrade.

Additional Info

There are a lot of dependencies update here, not all of which relate to index-provider. Please review carefully.

Current blocker for getting this PR ready for review is rolling out breaking changes of go-cid 0.2.0 across dependencies of Lotus.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k
Copy link
Contributor

magik6k commented Jun 22, 2022

Looks like carv2 dep doesn't build:

../go/pkg/mod/github.com/ipld/go-car/v2@v2.1.1/blockstore/readonly.go:283:15: undefined: blockstore.ErrNotFound

@masih
Copy link
Member Author

masih commented Jun 22, 2022

@masih
Copy link
Member Author

masih commented Jun 28, 2022

Upgrade required dependencies and fix breaking changes.
Upgrade to the latest go-fil-markets with dependency to go-blockstore
upgraded.
Address staticcheck issues caused by deprecated APIs and `go mod tidy`.
The quic transport implementation is now moved to `go-libp2p` mono repo.
Replace the dependency to the archived repo with the new one.

Regenerate CLI docs.
@arajasek
Copy link
Contributor

Replaced by #8945, thanks again Masih!

@arajasek arajasek closed this Jun 29, 2022
@masih masih deleted the masih/upgrade-idxprov branch June 30, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants