Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page size configuration option #306

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

ischasny
Copy link
Contributor

@ischasny ischasny commented Jan 5, 2023

Propagate page size to reframe configuration so that it can be changed without redeploying the service

@codecov-commenter
Copy link

Codecov Report

Base: 45.42% // Head: 45.15% // Decreases project coverage by -0.27% ⚠️

Coverage data is based on head (c79e216) compared to base (00436b9).
Patch coverage: 28.57% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   45.42%   45.15%   -0.28%     
==========================================
  Files          77       77              
  Lines        6087     6093       +6     
==========================================
- Hits         2765     2751      -14     
- Misses       2902     2917      +15     
- Partials      420      425       +5     
Impacted Files Coverage Δ
cmd/provider/daemon.go 0.00% <0.00%> (ø)
server/reframe/http/server.go 0.00% <0.00%> (ø)
cmd/provider/internal/config/reframe.go 31.70% <25.00%> (-0.73%) ⬇️
reframe/ds_wrapper.go 64.67% <100.00%> (+0.16%) ⬆️
mirror/mirror.go 52.86% <0.00%> (-5.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ischasny ischasny merged commit 24b458b into main Jan 5, 2023
@ischasny ischasny deleted the ivan/add-db-page-size-configuration branch January 5, 2023 22:05
@willscott
Copy link
Member

will we need to convert the reframe provider to use the newer http delegated routing api soon?

@ischasny
Copy link
Contributor Author

ischasny commented Jan 5, 2023

will we need to convert the reframe provider to use the newer http delegated routing api soon?

Yes, true. Snapshot paging + http will be very beneficial. On my to-do list.

@masih
Copy link
Member

masih commented Jan 9, 2023

Yes, true. Snapshot paging + http will be very beneficial. On my to-do list.

@ischasny is there a github issue for this? thanks

@ischasny
Copy link
Contributor Author

ischasny commented Jan 9, 2023

Good point - added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants