feat: publicly expose e2e TestIndexerRunner #2242
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2242 +/- ##
==========================================
+ Coverage 46.24% 47.24% +0.99%
==========================================
Files 80 83 +3
Lines 9613 9747 +134
==========================================
+ Hits 4446 4605 +159
+ Misses 4644 4608 -36
- Partials 523 534 +11
☔ View full report in Codecov by Sentry. |
test/testindexer.go
Outdated
| } | ||
| } | ||
| } | ||
| }() |
There was a problem hiding this comment.
I know that is what it did previously, but...
It seems strange to watch every command and see if its output contains something a watcher is looking for. Would it make more sense if ...watchers were a parameter to Start?
There was a problem hiding this comment.
A bit tricky because that's two lots of varargs, but if you have a look at the latest commit you'll see my attempt to resolve the problem by introducing a new Execution type that lets us build an "execution" and attach watchers to it d2bb69c
Ref: ipld/frisbii#36
This doesn't introduce anything new to the test, but exposes pieces in a way to make the runner framework reusable. It turns out that it's probably pretty useful just for generic test environments and maybe should even be its own package. But for now this works for me in Frisbii; see ipld/frisbii#36.