Introduction to GRPC blog #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkrish123
requested changes
Jan 26, 2023
Comment on lines
+171
to
+174
| reference. You can find on the application available on repository, shared on this article, some additional configurations | ||
| related to the familiar spring patterns. Among other things, we have a `@Configuration` class which is used to configure | ||
| our gRPC server to be running inside our spring application. In this configuratioon, `DerivativeCalculatorService` | ||
| houses our previously shown derivative logic. |
There was a problem hiding this comment.
Suggested change
| reference. You can find on the application available on repository, shared on this article, some additional configurations | |
| related to the familiar spring patterns. Among other things, we have a `@Configuration` class which is used to configure | |
| our gRPC server to be running inside our spring application. In this configuratioon, `DerivativeCalculatorService` | |
| houses our previously shown derivative logic. | |
| reference. You can find in the application available on the repository and shared in this article some additional configurations related to the familiar spring patterns. Among other things, we have a `@Configuration` class to configure our gRPC server to run inside our spring application. In this configuration, `DerivativeCalculatorService` houses our previously shown derivative logic. |
Comment on lines
+216
to
+218
| Feel free to play around with the example and try other simple polynomials. Some caveats when using this, be aware that | ||
| some requirements exist, for one, our polynomials we send include all exponents and coefficients (even 1 and 0), and | ||
| that’s why we see `1x^1 + 1x^0` instead of `x + 1`, this is simply due to our simple parsing of the string polynomial. |
There was a problem hiding this comment.
Suggested change
| Feel free to play around with the example and try other simple polynomials. Some caveats when using this, be aware that | |
| some requirements exist, for one, our polynomials we send include all exponents and coefficients (even 1 and 0), and | |
| that’s why we see `1x^1 + 1x^0` instead of `x + 1`, this is simply due to our simple parsing of the string polynomial. | |
| Feel free to play around with the example and try other simple polynomials. Some caveats when using this, be aware that the polynomials we send to the server must include all exponents and coefficients (even 1 and 0), and | |
| that’s why we see `1x^1 + 1x^0` instead of `x + 1`. This is simply due to our simple parsing of the string polynomial. |
|
|
||
| We’ve now completed our simple GRPC example, this has a small protobuf definition, but these can be much more complex, | ||
| if needed. We also created a simple docker configuration to get everything running locally and communication between | ||
| the service and client. |
There was a problem hiding this comment.
Add a conclusion and call to action pls! This was a really fun exercise to read about!
cjin-1
suggested changes
Jan 27, 2023
Comment on lines
+63
to
+64
| It seems like we have two simple ways to represent the polynomial, a naive way (which we handle in our rest | ||
| call) to do this is by sending it as a raw string. While this works, it could be cumbersome, as we will |
There was a problem hiding this comment.
2 simple ways... maybe state what they are first then go into the details?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.