Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CREATE3/4, *CALL2 instructions #64

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Rename CREATE3/4, *CALL2 instructions #64

merged 1 commit into from
Mar 4, 2024

Conversation

pdobacz
Copy link
Member

@pdobacz pdobacz commented Feb 26, 2024

Reasons to rename:

  • current names were temporary names which lasted a bit too long
  • avoid the sequel-based naming in instruction's mnemonics, conflicting with the PUSH1, 2, 3... convention
  • avoid conflict with previous meaning of CREATE3 used in some contexts

EOFCREATE creating from within an EOF container
TXCREATE creating from a transaction
EXT* is for consistency with legacy EXTCODEHASH and the like
Lastly, abbreviated versions were slightly preferred (i.e. no EXTDELEGATECALL)

@rakita
Copy link
Contributor

rakita commented Mar 3, 2024

TXCREATE and EOFCREATE are great names, liking them a lot!

EXT* prefix is slightly weird but are a lot better than CALL2.

For EXTSCALL, EXTDCALL only downside of shorted names is they are harder to read. EXTCALLS and EXTCALLDare maybe more readable and are aligned with CALLF, wdyt?

@pdobacz pdobacz self-assigned this Mar 4, 2024
@pdobacz
Copy link
Member Author

pdobacz commented Mar 4, 2024

For EXTSCALL, EXTDCALL only downside of shorted names is they are harder to read. EXTCALLS and EXTCALLDare maybe more readable and are aligned with CALLF, wdyt?

Thanks! To me personally EXTCALLS is a tiny tiny bit unfortunate, because is looking like plural "calls". Also less aligned with legacy "style". I'm going to move forward with this as is, since no strong objections were raised and for the sake of avoiding discussing this too long.

@pdobacz pdobacz merged commit 4ca9b4d into main Mar 4, 2024
2 checks passed
@pdobacz pdobacz deleted the rename-mnemonics branch March 4, 2024 16:45
pdobacz added a commit to pdobacz/EIPs that referenced this pull request Mar 5, 2024
pdobacz added a commit to pdobacz/EIPs that referenced this pull request Mar 5, 2024
pdobacz added a commit to pdobacz/EIPs that referenced this pull request Mar 5, 2024
pdobacz added a commit to pdobacz/EIPs that referenced this pull request Mar 7, 2024
pdobacz added a commit to pdobacz/execution-specs that referenced this pull request Mar 11, 2024
pdobacz added a commit to pdobacz/EIPs that referenced this pull request Mar 11, 2024
SamWilsn pushed a commit to ethereum/execution-specs that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants