Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change oob behavior of RETURNDATALOAD and RETURNDATACOPY #90

Merged
merged 2 commits into from
May 29, 2024

Conversation

charles-cooper
Copy link
Contributor

use zero-padding instead of exceptional halt

use zero-padding instead of exceptional halt
spec/eof.md Outdated Show resolved Hide resolved
@chfast
Copy link
Member

chfast commented May 22, 2024

Do I understand it correctly that Vyper is in favor of modifying the existing opcode instead of replacing it with a new opcode?

@charles-cooper
Copy link
Contributor Author

Do I understand it correctly that Vyper is in favor of modifying the existing opcode instead of replacing it with a new opcode?

Mildly in favor. It's not a huge issue, it just seems easier than adding a new opcode

(Fwiw my understanding is solidity is in favor too, but I can't speak for them)

Copy link

@ekpyron ekpyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm: yes, we're also in favour of this - this significantly simplifies optimizations since with this returndatacopy can be safely removed in all cases without changing semantics.
Also, for us changing the behaviour of the existing opcode is easier than any other solution (like removing it and introducing a new one) and we don't foresee any problems with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants