Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more xmltv_id's to "meo.pt" and "nostv.pt" channels.xml #2672

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

thomraider12
Copy link
Contributor

@thomraider12 thomraider12 commented Feb 2, 2025

First we need to add some channels to the database, which I already created a PR there.
I added some xmltv_id's, in which are in the commits. The PR on the database is for 5 of those channels.

Edit: since my PR got declined (no idea why), i'm going to create forms to recompensate.

fraudiay79
fraudiay79 previously approved these changes Feb 4, 2025
@PopeyeTheSai10r
Copy link
Collaborator

See the PR checks.

@thomraider12
Copy link
Contributor Author

See the PR checks.

I know, I mentioned that in my description.

@thomraider12
Copy link
Contributor Author

@BellezaEmporium
Copy link
Contributor

BellezaEmporium commented Feb 8, 2025

Declined :

channels:validate
npx tsx scripts/commands/channels/validate.ts sites/meo.pt/meo.pt.channels.xml sites/nostv.pt/nostv.pt.channels.xml

sites/meo.pt/meo.pt.channels.xml

│ 0 │ 'wrong_xmltv_id' │ 'pt' │ 'StarChannel.pt' │ 'STARCHA' │ 'STAR Channel' │
│ 1 │ 'wrong_xmltv_id' │ 'pt' │ 'StarComedy.pt' │ 'STARCOM' │ 'STAR Comedy' │
│ 2 │ 'wrong_xmltv_id' │ 'pt' │ 'StarCrime.pt' │ 'STARCRI' │ 'STAR Crime' │
│ 3 │ 'wrong_xmltv_id' │ 'pt' │ 'StarLife.pt' │ 'STARLIF' │ 'STAR Life' │
│ 4 │ 'wrong_xmltv_id' │ 'pt' │ 'StarMovies.pt' │ 'STARMOV' │ 'STAR Movies' │

sites/nostv.pt/nostv.pt.channels.xml

│ 0 │ 'wrong_xmltv_id' │ 'pt' │ 'StarChannel.pt' │ '174' │ 'STAR Channel' │
│ 1 │ 'wrong_xmltv_id' │ 'pt' │ 'StarComedy.pt' │ '113' │ 'STAR Comedy' │
│ 2 │ 'wrong_xmltv_id' │ 'pt' │ 'StarCrime.pt' │ '244' │ 'STAR Crime' │
│ 3 │ 'wrong_xmltv_id' │ 'pt' │ 'StarLife.pt' │ '175' │ 'STAR Life' │
│ 4 │ 'wrong_xmltv_id' │ 'pt' │ 'StarMovies.pt' │ '242' │ 'STAR Movies' │

Seen the database additions, let me check those. Should be as easy to move CR to CRLF.

@BellezaEmporium
Copy link
Contributor

Ok. The editor you used added extra unnecessary semicolons to the end of each line. I'll try to revert this from your repository part, please wait

@BellezaEmporium
Copy link
Contributor

Database PR reinstated, error solved. Please take note of the different errors mentioned by the bot and how to fix them.

@thomraider12
Copy link
Contributor Author

I put it as a draft because I'm waiting for the other PR to be approved, which has new channels from this list of updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants