Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observabiliy: Metrics capture and metrics "tracing" layer functionality ⚙️ #184

Open
1 of 4 tasks
Tracked by #331
zeeshanlakhani opened this issue Jul 8, 2023 · 0 comments
Open
1 of 4 tasks
Tracked by #331

Observabiliy: Metrics capture and metrics "tracing" layer functionality ⚙️ #184

zeeshanlakhani opened this issue Jul 8, 2023 · 0 comments
Assignees
@bgins
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@zeeshanlakhani
Copy link
Contributor

zeeshanlakhani commented Jul 8, 2023 •
edited by bgins
Loading

Summary

Need to capture metrics, via metrics-rs across the Homestar runtime, including libp2p metrics, workflows, etc.

This work will be iterative, but captures the larger issue/work at hand.

Description

Though geared to axum, our (fission) rust-template contains a lot of the necessary pieces already:

Components

ETA: 2023-12-20
@zeeshanlakhani zeeshanlakhani added good first issue Good for newcomers help wanted Extra attention is needed rust labels Jul 8, 2023
@zeeshanlakhani zeeshanlakhani changed the title Add (promethseus) metrics capture and metrics "tracing" layer functionality Add metrics capture and metrics "tracing" layer functionality Jul 8, 2023
@bgins bgins mentioned this issue Sep 7, 2023
Merged
13 tasks
bgins added a commit that referenced this issue Sep 14, 2023
@bgins @zeeshanlakhani
feat: Add out-of-band node metrics (#299)
1fad8c4 
# Description

This PR adds the following features:

- [x] Add system metrics
- [x] Add process metrics
- [x] Add network metrics
- [x] Add load average metric
- [x] Add database size metric
- [x] Add OS and kernel log entry
- [x] Add Prometheus exporter with endpoint for scraping
- [x] Move integration test utils into a separate module
- [x] Break Homestar process kills into *nix and windows functions
- [x] Switch from `serial` to `file_serial` in integration tests
- [x] Add `taplo` to pre-commit config and nix flake 

## Link to issue

Implements #184

## Type of change

- [x] New feature (non-breaking change that adds functionality)
- [x] Refactor

## Test plan (required)

We have an integration test in `homestar-runtime/tests/metrics.rs`.

---------

Co-authored-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins bgins mentioned this issue Sep 26, 2023
Closed
4 tasks
@zeeshanlakhani zeeshanlakhani changed the title Add metrics capture and metrics "tracing" layer functionality Observabiliy: Metrics capture and metrics "tracing" layer functionality Sep 27, 2023
@zeeshanlakhani zeeshanlakhani mentioned this issue Sep 27, 2023
Open
18 tasks
@zeeshanlakhani zeeshanlakhani changed the title Observabiliy: Metrics capture and metrics "tracing" layer functionality Observabiliy: Metrics capture and metrics "tracing" layer functionality ⚙️ Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgins bgins

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zeeshanlakhani @bgins