Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: homestar-core => homestar-invocation/homestar-workflow #506

Merged
merged 12 commits into from
Jan 18, 2024
Merged

chore: homestar-core => homestar-invocation/homestar-workflow #506

merged 12 commits into from
Jan 18, 2024

Conversation

zeeshanlakhani
Copy link
Contributor

Includes:

@zeeshanlakhani
chore: homestar-core => homestar-invocation/homestar-workflow
36623c2 
Includes:

- parallel test configuration, edits, and util updates
- doc shuffling
- run cargo test too
@zeeshanlakhani zeeshanlakhani requested a review from a team as a code owner January 18, 2024 03:34
@zeeshanlakhani
Copy link
Contributor Author

@bgins nightly issues stem from nextest-rs/nextest#1232 (not in our control, as it happens off main with the newest nightly).

So, up for review.

Zeeshan Lakhani and others added 2 commits January 18, 2024 12:43
@bgins
Update homestar-invocation/src/authority/prf.rs
9a1038b 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-invocation/src/authority/prf.rs
efbf94f 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-invocation/src/lib.rs
8066982 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
zeeshanlakhani and others added 3 commits January 18, 2024 13:09
@zeeshanlakhani
chore: updates
a70be4b
@bgins
Update homestar-invocation/src/pointer.rs
00a7496 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-invocation/src/task/result.rs
84ce9d4 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/receipt.rs
dbe6ce3 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
bgins
bgins reviewed Jan 18, 2024
View reviewed changes
homestar-workflow/src/lib.rs Outdated Show resolved Hide resolved
bgins
bgins approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice reorganization. ✨

@bgins
Update homestar-workflow/src/lib.rs
3f13a4e 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@zeeshanlakhani zeeshanlakhani merged commit 682118c into main Jan 18, 2024
23 of 29 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/the-snap branch January 18, 2024 19:34
This was referenced Jan 19, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgins bgins bgins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spec Integration: Split-out homestar-core form workflows so that core (invocations) can be used by rs-ucan
2 participants
@zeeshanlakhani @bgins