Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in snippets_menu pandas.js that breaks SnippetsMenu #1636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sjdemartini
Copy link

There was a syntax error introduced to the pandas snippets in commit d0fb866, since it attempted to use single quotes within a single-quoted string.

Without this fix, the Snippets menu would entirely fail to load if the built-in Pandas snippets are included (as is the default), with the dev tools console reporting Uncaught SyntaxError: Unexpected identifier 'label_count' (at pandas.js?v=20230413134100:119:39) 13:49:07.959 . This should resolve the problem and ensure that the default SnippetsMenu works again, and that pandas snippets can be included.


As a workaround until this is merged and published, for anyone who comes across this, you can uncheck the "Include pandas sub-menu" option for Snippets Menu in the Nbextensions UI, or equivalently set "snippets": {"include_submenu": { "pandas": false, } } within your nbconfig file (which can be found at echo $(jupyter --config-dir)/nbconfig/notebook.json).

There was a syntax error introduced to the snippets in commit d0fb866, since it attempted to use single quotes within a single-quoted string.

Without this fix, the Snippets menu would entirely fail to load if the built-in Pandas snippets are included (as is the default), with the dev tools console reporting `Uncaught SyntaxError: Unexpected identifier 'label_count' (at pandas.js?v=20230413134100:119:39)
13:49:07.959 `.
@yonghaoy
Copy link

Also for encountered this issue. Any ETA on when this can be fixed?
Also thank @sjdemartini for providing this walkaround

@yonghaoy
Copy link

yonghaoy commented Sep 13, 2023

@jcb91 for review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants