add spellchecker extension

[jcb91]

No description provided.

[jankatins]

Yay!

[jankatins]

Thanks but IMO there is no need for that (-> s/at the .*//). :-)

[jcb91]

Ah, you're welcome. Besides, I like to keep a history of where ideas come from, sometimes it's handy to remind yourself when you want to come back to something after not looking at it for some time!

[jankatins]

Tried it, it works: unfortunately no replacement suggestions :-(

@jcb91 Have you tried the other way with codemirror type "contenteditable" and then add a spellcheck=true to each span?

-> codemirror/codemirror5#1017 (comment)

[jcb91]

Yeah, no replacement suggestions as yet, although since Typo.js provides suggestions, I expect they could be added as a popover or something fairly easily. I didn't bother trying the contenteditable method, since as huangp notes in codemirror/codemirror5#1017 (comment), it doesn't trigger correct events for CodeMirror to update the text when replacements are used, which could lead to a whole bunch of weird inconsistent-state problems. Maybe I'll give it a try and see how horrible it is, though 😛

[jankatins]

re contenedible: from the above issue, I got the feeling that in 2014 they didn't want to include a contentedible part ("Okay, yeah, that uses contentEditable, which is not going to happen in CodeMirror.") but the documentation on this was included in 2015 and includes the wording

the "contenteditable" model. The intention is to make it the default on modern desktop browsers in the future.

But searching for spellcheckin the codemirror codebase, I found this: https://github.com/codemirror/CodeMirror/blob/877b2b1766a40bed35d5f035f15e01d8f9a66e4f/lib/codemirror.js#L1574

-> It seems that they disable spellcheck even if using contentedible, so maybe using contentedible and then adding the spellcheck attribute back would be already enough?

[jcb91]

True, they do seem to use contentEditable at least on mobile, so it may be worth a shot. The fact that they have explicitly disabled spellcheck makes me suspicious that the events won't cooperate, but whatever, we can give it a try, at least...

[jankatins]

Re disable spellcheck: this is also used on the "other version" and there it is used to disable the spellcheck on the (hidden?) textarea... So another explanation could be that they disabled it in the "regular" version and just used the same thing in the to-be-new version...

[jcb91]

OK, I've added a more complete explanation to the readme, including some python sample code, and actually tried switching to other dictionaries. It seems to work ok for me.

You've lost me a bit with the "other version" - I'm not quite sure what you mean?

[jcb91]

Unfortunately, it seems that the "contenteditable" model referred to in the docs doesn't actually set the contentEditable attribute at all... , which is exactly what you were saying. Apologies, I'm being a bit slow!

[jankatins]

Sorry: "other version" = whatever is not the "contenteditable" mode.

Actually I really thought, that setting the "contenteditable" mode in codemirror would use something in the backend which sets "contenteditable to the used html element. So it seems that I misled you :-( Sorry again!

[jcb91]

A few fixes, the most prominent being that I hadn't got raw downloads of the dictionaries - I managed to get round this by using the base64-encoded versions which are provided.

[jankatins]

Just to let you know: I'm using this now for a few days and I'm loving it. It would be perfect with suggestions, but this is great as it is :-)

[jcb91]

okey doke, I'll merge as-is then, and maybe add suggestions later on...