Use util function for upload to add authentication #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcb91
reviewed
Jan 5, 2017
| @@ -73,15 +73,14 @@ define([ | |||
| data : JSON.stringify(data), | |||
| headers : {'Content-Type': 'text/plain'}, | |||
| async : false, | |||
| success : function (data, status, xhr) { | |||
| error : function() {console.log('Data transfer for drag-and-drop failed.'); } | |||
There was a problem hiding this comment.
This will get ignored - see notebook/static/base/js/utils.js#L718
There was a problem hiding this comment.
I think you'll want instead a
utils.promising_ajax(url, settings).then(
function on_success (data, status, xhr) {/*...*/},
function on_error (reason) {/*...*/}
);pattern
|
I think I only copied the usage pattern from somewhere else. But you are right and I also should add the error path that is unused now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dragdrop extension due to security fix jupyter/notebook#2005
Should fix #830