fix: use comm package in backwards compatible way #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
fix_use_comm_backwards_compatible
branch
from
9d3c26d
to
736cb99
Compare
|
Not sure I understand what the |
It is not |
for more information, see https://pre-commit.ci
|
@martinRenou what's your take on this? Do you think it's preferred over: ipython/comm#6 I don't like the multiple inheritance, but hey, it works. |
|
I like this approach here! That way we can bypass the traitlets slowness with the new |
|
I'm on holiday, so I'll wait until next Monday to cut a release. |
|
Thanks a lot @blink1073, and enjoy your holiday ! Sorry for breaking everything right before your holiday 🥲 |
blink1073
added a commit
to blink1073/ipykernel
that referenced
this pull request
Dec 7, 2022
…)" This reverts commit c5a045f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the comm package, but in a backwards compatible way.
Alternative to ipython/comm#6
See