Add release process to CONTRIBUTING.md #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
minrk
commented
Sep 1, 2018
minrk
commented
- setup.py updated to use setuptools unconditionally (bdist_egg_disabled for disabling implicit eggs)
- setup.py adds setup_requires needed for the kernelspec step when installing from sdist (fixes Install broken on 4.9.0 / Python 2 #338)
- add release process to CONTRIBUTING.md
- simplifies logic - add bdist_egg_disabled to disable implicit eggs - add setup_requires to ensure we have what we need for setup.py building kernelspec from sdist
maybe this is why it's installing an incompatible IPython?
minrk
force-pushed
the
release-process
branch
from
bcc39a8 to
11348cb
Compare
since setup_requires just doesn't work
minrk
force-pushed
the
release-process
branch
from
2517719 to
153c0fe
Compare
|
Finally worked it out. |
Sorry to chime in here, but just out of curiosity: what pip/setuptools combo does require this? |
pip 10+ to make full use of the features, but that won't prevent it to work on earlier version IIUC. |
Carreau
approved these changes
Sep 5, 2018
|
This is a pretty minor issue, since the only thing that won't work with a too-old version of pip is implicitly pulling in build dependencies when installing from source. If the build dependencies are installed first, lacking this support will have no other consequences. |
|
Ok, let's get that in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.