use integer counter instead of loop.time() to preserve message ordering #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- avoids need to truncate comparison because it will always be unique - avoids sorting issues with low-resolution timers on Windows
|
Thanks @minrk! |
and increase default from 50 to 100 milliseconds due to reports of messages not being cancelled
|
I assume 5.1.0 will be available soon. The current error all over my scripts - I have to step run thru each very slowly to avoid cells being skipped or the run order wrong. |
|
5.1.0 was released over a week ago: https://anaconda.org/conda-forge/ipykernel/files for conda, https://pypi.org/project/ipykernel/#history for pypi. |
|
After upgrading to 5.1.0 on Windows I no longer see this issue.
…Sent from my iPhone
On 18 Oct 2018, at 16:50, Jason Grout ***@***.***> wrote:
5.1.0 was released over a week ago: https://anaconda.org/conda-forge/ipykernel/files for conda, https://pypi.org/project/ipykernel/#history for pypi.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Just upgraded – now have a new error. Will open an issue later after I try a couple of things.
The * that is generated for each cell when Restart & Run is clicked is gone on the first 4 cells and the line number correctly and in the right sequence shows up. The remaining 6 cells continue to contain the * even after they are executed.
Sent from Mail for Windows 10
From: esvhd
Sent: Thursday, October 18, 2018 1:30 PM
To: ipython/ipykernel
Cc: PCJimmmy; Comment
Subject: Re: [ipython/ipykernel] use integer counter instead of loop.time() topreserve message ordering (#362)
After upgrading to 5.1.0 on Windows I no longer see this issue.
Sent from my iPhone
On 18 Oct 2018, at 16:50, Jason Grout ***@***.***> wrote:
5.1.0 was released over a week ago: https://anaconda.org/conda-forge/ipykernel/files for conda, https://pypi.org/project/ipykernel/#history for pypi.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Because of issues with my PC I did a clean windows install on 10/11/2018. That day or the next (thinking it was the next) I did a full anaconda windows install – 5.0.0 was the version of ipykernel that was installed. Pretty sure I did a conda update all – so 5.1.0 might not be getting installed. Not going to do a new clean install to confirm.
Sent from Mail for Windows 10
From: Jason Grout
Sent: Thursday, October 18, 2018 11:50 AM
To: ipython/ipykernel
Cc: PCJimmmy; Comment
Subject: Re: [ipython/ipykernel] use integer counter instead of loop.time() topreserve message ordering (#362)
5.1.0 was released over a week ago: https://anaconda.org/conda-forge/ipykernel/files for conda, https://pypi.org/project/ipykernel/#history for pypi.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
"use integer counter instead of loop.time() to preserve message ordering" What does that even mean? How do i do that? What command do i input in jupyter to do that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #356
closes jupyter/notebook#4052
closes ipython/ipython#11348