Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stack levels for ipykernel's deprecation warnings and stop using some deprecated APIs #547

Merged
merged 4 commits into from
Sep 10, 2020
Merged

Fix stack levels for ipykernel's deprecation warnings and stop using some deprecated APIs #547

merged 4 commits into from
Sep 10, 2020

Conversation

Jackenmen
Copy link
Contributor

This PR:

  • fixes stack levels for ipykernel's deprecation warnings
  • stops using deprecated traitlets api for observing
  • uses the ipyparallel interfaces over the deprecated ipykernel variants when available
  • uses tornado's IOLoop when pyzmq version is 17 or greater

This greatly minimizes the amount of deprecation warnings from ipykernel.

@minrk minrk merged commit b7f14bf into ipython:master Sep 10, 2020
@minrk
Copy link
Member

minrk commented Sep 10, 2020

Great, thanks!

@Jackenmen Jackenmen deleted the fix_few_depr_warnings branch September 10, 2020 10:56
@Carreau Carreau added this to the 5.4 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Jackenmen @minrk @Carreau