Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernelspec: ensure path is writable before writing kernel.json. #593

Merged
merged 1 commit into from
Feb 18, 2021
Merged

kernelspec: ensure path is writable before writing kernel.json. #593

merged 1 commit into from
Feb 18, 2021

Conversation

jellelicht
Copy link
Contributor

Fixes #592

blink1073
blink1073 approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll make a release with this change tomorrow.

@blink1073 blink1073 added this to the 5.5 milestone Feb 18, 2021
@blink1073 blink1073 merged commit 164effa into ipython:master Feb 18, 2021
@ivanov ivanov mentioned this pull request May 15, 2021
Closed
@ivanov
Copy link
Member

ivanov commented May 15, 2021

Thanks for this, @jellelicht and @blink1073 - I just wanted to flag that we had a stale PR with an equivalent fix sitting around for about two years in #377 - so hopefully we can do better job catching such duplicates in the future.

@ivanov ivanov mentioned this pull request May 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.5
Development

Successfully merging this pull request may close these issues.

Cannot python3 -m ipykernel install when ipykernel is installed in read-only directory
3 participants
@jellelicht @ivanov @blink1073