stop control thread before closing sockets on it #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I don't know about the failures in ipykernel, but it fixed nbclient:
jupyter/nbclient#146
closing sockets in-use by another thread is a recipe for SIGABRT skip `close(all_fds=True)` in favor of explicit cleanup of sockets
|
failures were due to a missing check for is_alive, since this can still get called if the app never finishes starting. Should be okay, now. |
davidbrochart
approved these changes
May 7, 2021
|
Great, thanks! |
| try: | ||
| self.io_loop.start() | ||
| finally: | ||
| self.io_loop.close() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing sockets while they are still in use by another thread is a recipe for SIGABRT.
skip
close(all_fds=True)in favor of explicit cleanup of socketsI believe this fixes the nbclient failures in test_many_parallel_notebooks mentioned here.
I'm not sure why that test would have triggered it and not others, but it was readily reproducible for me and doesn't happen anymore after this.