Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Backwards compat with older versions of zmq #665

Merged
merged 1 commit into from
May 12, 2021

Conversation

mlucool
Copy link
Contributor

@mlucool mlucool commented May 10, 2021

zmq.ROUTING_ID was added in libzmq 4.2.3 as an alias for IDENTITY.

@Carreau
Copy link
Member

Carreau commented May 11, 2021

@mlucool your commit author does not match you github email; not sure if that's matter to you.
I'm guessing this should be backported to the 5.5.x branch, or 5.x branch.

zmq.ROUTING_ID was added in libzmq 4.2.3 as an alias for IDENTITY.
@mlucool
Copy link
Contributor Author

mlucool commented May 11, 2021

@mlucool your commit author does not match you github email; not sure if that's matter to you.

I fixed it, but it was mostly correct.

I'm guessing this should be backported to the 5.5.x branch, or 5.x branch.

This only is for the debugger, which I don't think is in 5.x.

@SylvainCorlay
Copy link
Member

cc @JohanMabille

@JohanMabille
Copy link
Contributor

This only is for the debugger, which I don't think is in 5.x.

Indeed the debugger is in 6.x only.

@SylvainCorlay SylvainCorlay merged commit 30d5588 into ipython:master May 12, 2021
@blink1073 blink1073 added this to the 6.0 milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants