RFC: kernelapp: rename ports variable to avoid override #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"ports" is a property defined in ConnectionFileMixin and used internally by it To avoid attribute name colission, rename "ports" to "_ports" Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #730, it seems ConnectionFileMixin is expecting
portsto be List[int].https://github.com/jupyter/jupyter_client/blob/5742d84ca2162e21179d82e8b36e10baf0f8d978/jupyter_client/connect.py#L386
IPKernelApp is overriding such attribute and changing its type, which generates the error described.
This is the simplest fix I could come up with. Since I am not familiar with the project, please take this as a suggestion.
#Fixes 730
Signed-off-by: Adrian Moreno amorenoz@redhat.com