Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rich variables inspection #793

Merged
merged 5 commits into from
Oct 29, 2021
Merged

Conversation

fcollonval
Copy link
Contributor

@fcollonval fcollonval commented Oct 29, 2021

This fixes rich variables inspection both for inspection outside breakpoints and on subframe.

Add unit test for that part of the code


Closes #772 as this will use user_expressions to get the representation of variables outside stopped threads.

@fcollonval
Copy link
Contributor Author

This PR pushes first only the unit tests to demonstrate the current code is not working. The second commit will include the fix.

@fcollonval fcollonval marked this pull request as ready for review October 29, 2021 15:06
@blink1073 blink1073 added the bug label Oct 29, 2021
@blink1073 blink1073 added this to the 6.5 milestone Oct 29, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit e8d4f66 into ipython:master Oct 29, 2021
@fcollonval fcollonval deleted the fix/rich-inspect branch October 29, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich variable inspection vs user_expressions
2 participants