Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing upgrades #868

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Typing upgrades #868

merged 4 commits into from
Sep 26, 2023

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Sep 22, 2023

Fixes #863

  • Adds types to class __init__ methods
  • Adds types to decorators
  • Adds tests for failing cases in nbconvert and addresses them

@blink1073 blink1073 merged commit c0a3afd into ipython:main Sep 26, 2023
27 checks passed
@blink1073 blink1073 deleted the trait-type-fixes branch September 26, 2023 13:06
@maartenbreddels
Copy link
Contributor

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with trait typing
2 participants