secrecy/zeroize: Upgrade to bytes v0.5; MSRV 1.39+
#301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes the `bytes-preview` feature from `zeroize` - Upgrades `secrecy` to use `bytes` v0.5 Now that `bytes` v0.5 is out, I've opened a PR to upstream the `Zeroize` impl for `BytesMut`: tokio-rs/bytes#335 Unfortunately it's no-longer possible to impl `Zeroize` for `Bytes` as of `bytes` v0.5, as the `try_mut` method was dropped in this PR: tokio-rs/bytes#298 I have brought this up on the first PR. In the meantime, this vendors the previous `BytesMut` impl of `Zeroize` into `secrecy`'s `SecretBytesMut` type, and drops `SecretBytes` as it's no-longer possible to implement.
`bytes` v0.5 now needs Rust 1.39. 1.39 is a pretty foundational release in terms of adding `async`/`await` and we need to be able to target that in various ways ASAP. Note this change is to the documented/supported/tested MSRV. Crates will continue working on a lower-than-advertised MSRV for now.
tony-iqlusion
changed the title
bytes v0.5bytes v0.5; MSRV 1.39+
Merged
Merged
gakonst
added a commit
to interledger/interledger-rs
that referenced
this pull request
Jan 15, 2020
This is done due to the recent Secrecy breaking changes induced by Bytes 0.5 tokio-rs/bytes#335 iqlusioninc/crates#301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bytes-previewfeature fromzeroizesecrecyto usebytesv0.5Now that
bytesv0.5 is out, I've opened a PR to upstream theZeroizeimpl forBytesMut:tokio-rs/bytes#335
Unfortunately it's no-longer possible to impl
ZeroizeforBytesas ofbytesv0.5, as thetry_mutmethod was dropped in this PR:tokio-rs/bytes#298
I have brought this up on the first PR.
In the meantime, this vendors the previous
BytesMutimpl ofZeroizeintosecrecy'sSecretBytesMuttype, and dropsSecretBytesas it's no-longer possible to implement.