COMP-1097: No realm and client id config in cortex init #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also support an onption to overwrite the value with a command line switch --client-id
Also support an option to overwrite the value with a command line switch --realm Use "is_eager" flag to sort options so they get processed in the right order. Without the flag options passed via command line would get processed first. This would not work with realm option, because realm validation callback would be called prior to have validated auth server URL Use decorator "help_option" with combination of "is_eager" to make sure option "--help" is processed first. Without this command "cortex init --help" would first run the init and only then show help message. And this is not the behavior we need
ollityrkko
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.