Add iqm fake aphrodite #113
Conversation
| def test_iqm_fake_aphrodite(): | ||
| backend = IQMFakeAphrodite() | ||
| assert backend.num_qubits == 54 | ||
| assert backend.name == 'IQMFakeAphroditeBackend' | ||
|
|
||
|
|
||
| def test_iqm_fake_aphrodite_connectivity(aphrodite_coupling_map): | ||
| backend = IQMFakeAphrodite() | ||
| assert set(backend.coupling_map.get_edges()) == aphrodite_coupling_map | ||
|
|
||
|
|
||
| def test_iqm_fake_aphrodite_noise_model_instantiated(): | ||
| backend = IQMFakeAphrodite() | ||
| assert isinstance(backend.noise_model, NoiseModel) |
There was a problem hiding this comment.
These tests mainly check if the python interpreter works, but they are in line with the existing tests for FakeBackends. It's good for now, but I'll make a ticket to improve FakeBackend testing.
@Aerylia It was my understanding that the CI test fails due to "duplicate code" between the noise model for aphrodite and apollo. This is because the values themselves are copy and pasted. I am not sure how to fix this issue other than use different values. The values are placeholders anyway if we follow the convention from #66 |
Co-authored-by: Arianne Meijer <ariannemeijer@gmail.com>
|
For next time: The duplicate code linting issue can be fixed with I've made the changes and updated the branch with main. So it's ready to merge when checks pass. |
Hi, this pull request adds
IQMFakeAphroditeto provide noisy simulation of IQM's Aphrodite chip. I created the changes based off IQMFakeApollo. The values are currently placeholder values which are open to be changed by the maintainers. They are based off #66.Should any documentation be added regarding this PR? Let me know and I will add it.
Additionally, I added 1 comment to
CONTRIBUTING.rstto inform contributors that they can run the formatting through tox.Note that the tests will fail due to duplicate code as the values are copied from IQM fake apollo