Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Test enhancement #15

Merged
merged 1 commit into from
Jan 5, 2019
Merged

Conversation

peter279k
Copy link
Contributor

@peter279k peter279k commented Jan 4, 2019

Changed log

  • Remove --configuration option from phpunit command during Travis CI build because this option cannot be added when the phpunit.xml path is same as execution command path.
  • Add php-7.3 test in Travis CI build.
  • Replace try...catch block with expectException and expectExceptionMessage methods.
  • Replace 'Exception' with \Exception::class for all expectException method.
  • Using assertCount method to assert whether the array length is same as expected count.
  • Using assertArrayHasKey to assert the specific key is existed in $result array.
  • Using assertArrayNotHasKey to assert the specific key is not existed in $result array.

@iranianpep iranianpep merged commit f9e9007 into iranianpep:master Jan 5, 2019
@iranianpep
Copy link
Owner

Thanks @peter279k. I bumped up the release number.

@peter279k peter279k deleted the test_enhancement branch January 5, 2019 04:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants