make BASE_BOT_URL customizable #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR will close the #941 and #942
as you know telegram offers a local bot API server and in some cases like censorship we can use a proxy to send our requests to telegram for example using this repo https://github.com/manzoorwanijk/telegram-bot-api-worker we can create a Cloudflare worker to send requests to the telegram sever in restricted internet and all these situations need custom BASE_BOT_URL.
I've added a fourth parameter to the API Class that accepts BASE_BOT_URL and for laravel users, I've added a config option called
base_bot_urlso that users can set their custom bot base URL.function
setBaseBotUrl(string $baseBotUrl)was also added to the API class.